lkml.org 
[lkml]   [2014]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 0/6] ARM: sunxi: Add driver for SD/MMC hosts found on allwinner sunxi SOCs
Date
Hi Maxime
> I have four comments here:
> - Read Documentation/SubmittingPatches, especially Section 5 and 12
> (hints, you forgot the clock maintainers for your clock patches
> and you didn't put any signed-off-by tags)
Oops. I added signed-offs now
> - You ignored pretty much all the comments that were made during the
> review of the first version. Go through
Uh? I just fixed the commits and squashed them together for easier handling.
I'm even using mmc_of_parse now...
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-December/219339.
> html and address the comments that were made.
> - Each of your patches should compile. Fix the order of your
> patches.
Done.
> - Submit a v3, with the changes you made. Otherwise we have no way
> of knowing what have been fixed and what didn't
Too many patches would be bloaty.
That's why I've squashed them into small and corrected patches.

> Looking forward for the next iteration!
Good :-)
You can have a look at the recent status here:
http://git.o2s.ch/?p=linux-next.git;a=shortlog;h=refs/heads/20140205

cheers
David[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-02-05 14:41    [W:0.122 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site