lkml.org 
[lkml]   [2014]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 16/18] charger: max14577: Add support for MAX77836 charger
    From
    Date
    Hi,

    On Mon, 2014-02-03 at 17:00 +0530, Jenny Tc wrote:
    > On Tue, Jan 28, 2014 at 01:18:40PM +0100, Krzysztof Kozlowski wrote:
    > > - /* Battery-Charger Constant Voltage (CV) Mode, from SM-V700: 4.35V */
    > > + /* Battery-Charger Constant Voltage (CV) Mode, set to: 4.35V */
    >
    > Does this charger chip support only 4.35V batteries? If the CV is hard coded
    > to 4.35V, it's not safe for 4.2V batteries.
    >
    > > + /* End-of-Charge Current, set to 50mA (max14577) / 7.5mA (max77836) */
    > The End of charge current basically depend on battery and not on charger chip.
    >
    > > - /* Overvoltage-Protection Threshold, from SM-V700: 6.5V */
    > > + /* Overvoltage-Protection Threshold, set to 6.5V */
    > 6.5V as over voltage for battery? A 4.35V battery would have exploded by
    > that time!

    Currently the max14577 driver has all these values hard-coded. This
    patch doesn't change this, it only adds support for max77836. I agree
    with you that hard-coding these values is not a proper way of doing
    this.

    I'll add another patch for parsing these values from DTS.

    Best regards,
    Krzysztof





    \
     
     \ /
      Last update: 2014-02-05 14:41    [W:3.092 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site