Messages in this thread | | | Date | Tue, 4 Feb 2014 11:32:10 -0500 | From | Johannes Weiner <> | Subject | Re: [PATCH -v2 5/6] memcg, kmem: clean up memcg parameter handling |
| |
On Tue, Feb 04, 2014 at 02:28:59PM +0100, Michal Hocko wrote: > memcg_kmem_newpage_charge doesn't always set the given memcg parameter.
lol, I really don't get your patch order...
> Some early escape paths skip setting *memcg while > __memcg_kmem_newpage_charge down the call chain sets *memcg even if no > memcg is charged due to other escape paths. > > The current code is correct because the memcg is initialized to NULL > at the highest level in __alloc_pages_nodemask but this all is very > confusing and error prone. Let's make the semantic clear and move the > memcg parameter initialization to the highest level of kmem accounting > (memcg_kmem_newpage_charge). > > Signed-off-by: Michal Hocko <mhocko@suse.cz>
Patch looks good, though.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |