lkml.org 
[lkml]   [2014]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/4] xen-blkback: fix memory leaks
    On 04/02/14 10:26, Roger Pau Monne wrote:
    > I've at least identified two possible memory leaks in blkback, both
    > related to the shutdown path of a VBD:
    >
    > - blkback doesn't wait for any pending purge work to finish before
    > cleaning the list of free_pages. The purge work will call
    > put_free_pages and thus we might end up with pages being added to
    > the free_pages list after we have emptied it. Fix this by making
    > sure there's no pending purge work before exiting
    > xen_blkif_schedule, and moving the free_page cleanup code to
    > xen_blkif_free.
    > - blkback doesn't wait for pending requests to end before cleaning
    > persistent grants and the list of free_pages. Again this can add
    > pages to the free_pages list or persistent grants to the
    > persistent_gnts red-black tree. Fixed by moving the persistent
    > grants and free_pages cleanup code to xen_blkif_free.
    >
    > Also, add some checks in xen_blkif_free to make sure we are cleaning
    > everything.

    Reviewed-by: David Vrabel <david.vrabel@citrix.com>

    > + if (log_stats)
    > + print_stats(blkif);

    Unrelated to this series, but this log_stats stuff can be removed.

    David


    \
     
     \ /
      Last update: 2014-02-04 12:01    [W:2.991 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site