lkml.org 
[lkml]   [2014]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1] fix da9052 volatile register definition ommissions
> > > Three of the PMIC registers have some bits that are changed
> > > autonomously by the PMIC itself (some time) after being set by some
> > > component driver of the DA9052 PMIC and hence they need to be marked
> > > as volatile so that the regmap API will not cache their values.
> > > Signed-off-by: Anthony Olech <anthony.olech.opensource@diasemi.com>
> > > Signed-off-by: David Dajun Chen <david.chen@diasemi.com>
> > These are not correct.
> > Who authored the patch?
>
> I found the problem when running regression tests for another different problem.
> And according to my testing on a SMDK6410+DA9053EVB the patch is correct!!

I mean the Signed-off-by's are not correct.

They should be in order of the patch submission path.

Who authored the patch initially and what part did David play?

<snip>

> > > REGULATORS - the first change to any DA9052 BUCK voltage will be
> > > actioned, but sebsequent ones will not.
> > Which patch caused the bug?
>
> I will find out when I start rebasing backwards to submit patches to linux-stable!

I'm just wondering where to apply the patch. Either for -fixes or
-next. If the bug has been present for some time, I'll probably just
apply it to my for-next branch.

Also be wary of the $SUBJECT line format when submitting to different
subsystems. You can usually get an idea of what's expected by doing:

`git log --oneline -- drivers/<subsystem>`

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-02-03 18:21    [W:0.063 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site