lkml.org 
[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS

    > > Also, the I2C tracing has first 'f' then 'a', that should be consistent,
    > > too.
    >
    > Flags first or address first? Do you have a preference (for both)?

    I'd say address first, yet no strong preference.

    > > Can we have something like this for 'flags'?
    >
    > There's a __print_flags() which should work. One thing I'm concerned about
    > there is how do we handle more flags being added - does that count as an ABI
    > break if the printed format changes?

    Not sure, I mean, this is debug output, no?

    > SMBus flags are basically the same as I2C flags, right?

    Basically, yes.

    Thanks,

    Wolfram

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-02-28 23:01    [W:2.256 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site