Messages in this thread Patch in this message | | | From | shuox.liu@intel ... | Subject | [PATCH] pstore: skip zero size persistent ram buffer in traverse | Date | Fri, 28 Feb 2014 14:38:21 +0800 |
| |
From: Liu ShuoX <shuox.liu@intel.com>
In ramoops_pstore_read, a valid prz pointer with zero size buffer will break traverse of all persistent ram buffers. The latter buffer might be lost.
Signed-off-by: Liu ShuoX <shuox.liu@intel.com> --- fs/pstore/ram.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index a5d0cab..929ea55 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -119,12 +119,12 @@ ramoops_get_next_prz(struct persistent_ram_zone *przs[], uint *c, uint max, prz = przs[i]; - if (update) { - /* Update old/shadowed buffer. */ + /* Update old/shadowed buffer. */ + if (update) persistent_ram_save_old(prz); - if (!persistent_ram_old_size(prz)) - return NULL; - } + + if (!persistent_ram_old_size(prz)) + return NULL; *typep = type; *id = i; -- 1.8.3.2
| |