Messages in this thread | | | Subject | Re: [PATCH 2/2] timer: Make sure TIMER_FLAG_MASK bits are free in allocated base | From | Viresh Kumar <> | Date | Fri, 28 Feb 2014 22:21:50 +0530 |
| |
> On 28-Feb-2014, at 4:22 pm, Thomas Gleixner <tglx@linutronix.de> wrote: > >> On Fri, 28 Feb 2014, Viresh Kumar wrote: >> >> Currently we are using two lowest bit of base for internal purpose and so they >> both should be zero in the allocated address. The code was doing the right thing >> before this patch came in: >> >> commit c5f66e99b7cb091e3d51ae8e8156892e8feb7fa3 >> Author: Tejun Heo <tj@kernel.org> >> Date: Wed Aug 8 11:10:28 2012 -0700 >> >> timer: Implement TIMER_IRQSAFE >> >> Tejun probably forgot to update this piece of code which checks if the lowest >> 'n' bits are zero or not and so wasn't updated according to the new flag. Lets >> use TIMER_FLAG_MASK in the calculations here, so that this code wouldn't require >> a change later on with another flag in. > > Are you planning to introduce more flag horror? Don't go there. The > timer_list code is about to be rewritten completely and I'm not going > to add new features to the existing code base.
Not at all. I was just trying to understand this framework and found this Issue.
| |