Messages in this thread Patch in this message | | | From | Florian Vaussard <> | Subject | [PATCH v2 2/2] checkpatch: fix spurious vendor compatible warnings | Date | Fri, 28 Feb 2014 17:25:42 +0100 |
| |
With a compatible string like
compatible = "foo";
checkpatch will currently try to find "foo" in vendor-prefixes.txt, which is wrong since the vendor prefix is empty in this specific case.
Skip the vendor test if the compatible is not like
compatible = "vendor,something";
Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e304e77..7437505 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2058,6 +2058,7 @@ sub process { my $vendor = $compat; my $vendor_path = $dt_path . "vendor-prefixes.txt"; next if (! -f $vendor_path); + next if not $vendor =~ /^[a-zA-Z0-9\-]+\,.*/; $vendor =~ s/^([a-zA-Z0-9\-]+)\,.*/$1/; `grep -Eq "$vendor" $vendor_path`; if ( $? >> 8 ) { -- 1.8.5.3
| |