lkml.org 
[lkml]   [2014]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/5] hwrng: pixocell - Use devm_clk_get()
    Date
    Use devm_clk_get() to make cleanup paths simpler.

    Signed-off-by: Jingoo Han <jg1.han@samsung.com>
    ---
    drivers/char/hw_random/picoxcell-rng.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    diff --git a/drivers/char/hw_random/picoxcell-rng.c b/drivers/char/hw_random/picoxcell-rng.c
    index c03beee..eab5448 100644
    --- a/drivers/char/hw_random/picoxcell-rng.c
    +++ b/drivers/char/hw_random/picoxcell-rng.c
    @@ -108,7 +108,7 @@ static int picoxcell_trng_probe(struct platform_device *pdev)
    if (IS_ERR(rng_base))
    return PTR_ERR(rng_base);

    - rng_clk = clk_get(&pdev->dev, NULL);
    + rng_clk = devm_clk_get(&pdev->dev, NULL);
    if (IS_ERR(rng_clk)) {
    dev_warn(&pdev->dev, "no clk\n");
    return PTR_ERR(rng_clk);
    @@ -117,7 +117,7 @@ static int picoxcell_trng_probe(struct platform_device *pdev)
    ret = clk_enable(rng_clk);
    if (ret) {
    dev_warn(&pdev->dev, "unable to enable clk\n");
    - goto err_enable;
    + return ret;
    }

    picoxcell_trng_start();
    @@ -132,9 +132,6 @@ static int picoxcell_trng_probe(struct platform_device *pdev)

    err_register:
    clk_disable(rng_clk);
    -err_enable:
    - clk_put(rng_clk);
    -
    return ret;
    }

    @@ -142,7 +139,6 @@ static int picoxcell_trng_remove(struct platform_device *pdev)
    {
    hwrng_unregister(&picoxcell_trng);
    clk_disable(rng_clk);
    - clk_put(rng_clk);

    return 0;
    }
    --
    1.7.10.4



    \
     
     \ /
      Last update: 2014-02-27 06:45    [W:4.185 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site