Messages in this thread | | | Date | Thu, 27 Feb 2014 12:55:28 -0800 | Subject | Re: [PATCH V2] sparse: Allow override of sizeof(bool) warning | From | Christopher Li <> |
| |
On Thu, Feb 27, 2014 at 12:39 PM, Joe Perches <joe@perches.com> wrote: > Please use V3 as I stuffed up the alphabetic order > of sizeof and shadow.
Please send it your V3 then :-)
> > I'm not sure it matters much, but the linux-kernel > Makefile wouldn't need to be changed if Wsizeof_bool > is default 0.
It seems default to off is the right thing to do.
> > Here's a couple of other nits: > > Maybe the evaluate.c "size = bits_in_char;" assignment > > if (size == 1 && is_bool_type(type)) { > - warning(expr->pos, "expression using sizeof bool"); > + if (Wsizeof_bool) > + warning(expr->pos, "expression using sizeof bool"); > size = bits_in_char; > } > > should be > > size = sizeof(_Bool) * 8;
The reason to use bits_in_xxxx is to allow sparse application to over write the size of int etc. If you don't like the bits_in_char here. You can introduce bits_in_bool and set that to sizeof(Bool)*8 by default. That way you don't hard code it.
> And also, in sparse.1, Josh Triplett is shown as > the maintainer. Maybe that should be changed to > Christopher Li
Maybe a separate patch.
Waiting for your V3.
Chris
| |