[lkml]   [2014]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS
Wolfram Sang <> wrote:

> Although SMBus has no 10-bit addresses, we probably should also use %03x
> there for consistency reasons?


> Also, the I2C tracing has first 'f' then 'a', that should be consistent,
> too.

Flags first or address first? Do you have a preference (for both)?

> 'flags' should be %04x again


> and I'd prefer %*ph (or %*phD) for the buffer.

Again, I'm not so certain.

> Can we have something like this for 'flags'?

There's a __print_flags() which should work. One thing I'm concerned about
there is how do we handle more flags being added - does that count as an ABI
break if the printed format changes?

SMBus flags are basically the same as I2C flags, right?


 \ /
  Last update: 2014-02-27 15:01    [W:0.097 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site