Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C | Date | Thu, 27 Feb 2014 13:07:24 +0000 |
| |
Wolfram Sang <wsa@the-dreams.de> wrote:
> 'flags' are u16 and the whole range is needed -> %04x
Done. Note that %02x does not preclude more digits, but I guess it's better to have things line up.
> for the address simply %03x should do.
Done.
> And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or > %*phD at least?
My problem with that is that it increases the length of the output by 50% and there's a hard limit on how much output we may produce.
David
| |