lkml.org 
[lkml]   [2014]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] gpio / ACPI: Embed events list directly into struct acpi_gpio_chip
On Tue, Feb 25, 2014 at 03:26:12PM +0100, Rafael J. Wysocki wrote:
> On Monday, February 24, 2014 06:00:09 PM Mika Westerberg wrote:
> > It is not necessary to have events as a pointer to list in struct
> > acpi_gpio_chip. Instead we can embed the list_head directly to struct
> > acpi_gpio_chip itself. This makes event handling a bit simpler because now
> > we don't need to check whether the pointer is NULL or not.
>
> It looks like I should have reviewed the whole series before commenting [2/6].
>
> Well, my modified comment would be "Why don't you fold this one into [2/6]?", then.

I will in the next version, thanks.


\
 
 \ /
  Last update: 2014-02-26 10:41    [W:0.206 / U:1.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site