lkml.org 
[lkml]   [2014]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2] sparse: Allow override of sizeof(bool) warning
    On Wed, Feb 26, 2014 at 07:38:46PM -0800, Joe Perches wrote:
    > (adding Ben Pfaff and Christopher Li)
    >
    > On Wed, 2014-02-26 at 19:29 -0800, H. Peter Anvin wrote:
    > > On 02/26/2014 06:58 PM, Josh Triplett wrote:
    > > > On Wed, Feb 26, 2014 at 06:53:14PM -0800, Joe Perches wrote:
    > > >> Allow an override to emit or not the sizeof(bool) warning
    > > >> Add a description to the manpage.
    > > >>
    > > >> Signed-off-by: Joe Perches <joe@perches.com>
    > > >
    > > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
    > > >
    > >
    > > I have to admit that this particular warning is a bit odd to me. I'm
    > > wondering what kind of bugs it was intended to catch.
    > >
    > > In particular, things that incorrectly assumes the size of bool to be
    > > anything in particular would seem unlikely to actually use sizeof().
    >
    > Dunno, the commit log for the commit that added it doesn't quite
    > match the code and is seemingly unaware that the c99 spec doesn't
    > specify sizeof(bool).

    The commit *relaxed* sparse behavior: because previously sizeof(bool)
    was an error. I'm not in favor of any diagnostic at all for
    sizeof(bool), but my recollection is that a sparse maintainer wanted it
    to yield one.

    I don't care about the particular result for sizeof(bool) as long as it
    matches the ABI.


    \
     
     \ /
      Last update: 2014-02-27 06:01    [W:2.645 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site