lkml.org 
[lkml]   [2014]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] drivers: cpufreq: Mark function as static in cpufreq.c
Date
On Wednesday, February 26, 2014 02:16:51 PM josh@joshtriplett.org wrote:
> On Wed, Feb 26, 2014 at 10:56:45PM +0100, Rafael J. Wysocki wrote:
> > On Wednesday, February 26, 2014 10:12:42 PM Rashika Kheria wrote:
> > > Mark function as static in cpufreq.c because it is not
> > > used outside this file.
> > >
> > > This eliminates the following warning in cpufreq.c:
> > > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]
> > >
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> >
> > v2 has been Reviewed-by: Josh already, right?
>
> Feel free to forward-propagate to v3 as well, if that helps.

OK

Applied, thanks!

> > > ---
> > > Changes since v1:
> > > Incorrect Fix
> > > Changes since v2:
> > > Show Changelog
> > >
> > > drivers/cpufreq/cpufreq.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > > index 08ca8c9..54fd670 100644
> > > --- a/drivers/cpufreq/cpufreq.c
> > > +++ b/drivers/cpufreq/cpufreq.c
> > > @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
> > > /*********************************************************************
> > > * SYSFS INTERFACE *
> > > *********************************************************************/
> > > -ssize_t show_boost(struct kobject *kobj,
> > > +static ssize_t show_boost(struct kobject *kobj,
> > > struct attribute *attr, char *buf)
> > > {
> > > return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
> > >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-02-27 01:41    [W:0.169 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site