Messages in this thread | | | Date | Wed, 26 Feb 2014 21:22:22 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: phy: add suspend_halted module param |
| |
> The only case we need to handle is when the interface is brought down, > suspend_halted=true will also power down the PHY, you reboot into > u-boot, and you attempt a network boot right after that, in that case > the PHY interface is still powered down and this does not work.
Correct. And since my device uses dhclient, the interface is always put down on reboot when it releases the lease.
> That could be worked around by putting the interface up again before > you reboot into u-boot right, that specific logic being gated by > reading the board model. Agreed, you need to duplicate that workaround > in all affected user-space....
I wonder how many other systems are broken? Are we considering this a regression? Should this feature to turned off by default, and a sysfs knob used to enable it? That is the safe option.
Andrew
| |