lkml.org 
[lkml]   [2014]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] backlight: add PWM dependencies
    On Mon, Feb 10, 2014 at 12:09:29PM +0100, Linus Walleij wrote:
    > On Mon, Feb 10, 2014 at 11:40 AM, Thierry Reding
    > <thierry.reding@gmail.com> wrote:
    >
    > > it seems like at least BACKLIGHT_LP8788 is missing a corresponding
    > > dependency as well.
    > >
    > > I have applied Sascha's patch to remove the obsolete HAVE_PWM symbol,
    > > and this will fix at least the build issues. However it will also cause
    > > the driver to fail at runtime because the pwm_*() functions won't work.
    >
    > So it definately needs that API, not just stubs.
    >
    > But isn't it proper for Kconfig to allow you to break things
    > like that by configuring out stuff and have stubs come in?
    >
    > I'm a bit torn here.

    After thinking about this some more, I've come to the conclusion that
    the drivers should have the dependency. Kconfig should make sure that
    the resulting drivers work.

    If somebody wanted to knowingly build this driver with a configuration
    that won't work at runtime, then they should be using COMPILE_TEST
    instead.

    So I'm leaning towards applying this patch if there are no objections.

    Thierry
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-02-26 15:01    [W:3.976 / U:1.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site