lkml.org 
[lkml]   [2014]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: kdoc struct net_device flags and priv_flags
From
Date
On Mon, 2014-02-24 at 23:53 -0500, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Tue, 25 Feb 2014 02:11:05 +0000
>
> > On Mon, 2014-02-24 at 16:14 -0800, Luis R. Rodriguez wrote:
> >> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> >>
> >> ---
> >> include/uapi/linux/if.h | 201 +++++++++++++++++++++++++++++++++++-------------
> >> 1 file changed, 149 insertions(+), 52 deletions(-)
> >>
> >> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
> >> index d758163..1555623 100644
> >> --- a/include/uapi/linux/if.h
> >> +++ b/include/uapi/linux/if.h
> > [...]
> >> +/**
> >> + * enum net_device_priv_flags - &struct net_device priv_flags
> >> + *
> >> + * These are the &struct net_device, they are only set internally
> >> + * by drivers and used in the kernel but are invisible to userspace.
> > [...]
> >
> > Indeed, I wonder why they are in the UAPI header. As userland doesn't
> > have a legitimate use for them, maybe you could move them back to
> > include/linux/if.h instead of bothering with adding macros?
>
> They are visible to userspace via sysfs.

Really, I don't see them. Also they were renumbered a while ago (commit
080e4130b1fb) so they're not a stable interface.

> My memory may be bad, but I believe this has been brought up before.

I expect it has, yes.

Ben.

--
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
- Albert Einstein
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-02-25 15:21    [W:0.086 / U:4.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site