Messages in this thread | | | Date | Tue, 25 Feb 2014 09:56:07 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH] Staging: comedi: addi-data: clean-up variable use in hwdrv_apci035.c |
| |
On 2014-02-25 08:15, Chase Southwood wrote: > The static variable ui_Command is as of right now being cleared to a > value of zero between everytime that it writes to a port and then takes a > new value from a port. Seems like this zeroing is unnecessary, so we can > just remove these lines.
The description is slightly wrong as the variable isn't static storage class.
> > Signed-off-by: Chase Southwood <chase.southwood@yahoo.com> > --- > This sort of thing seems like a copy/paste sort of error to me, but there > could as easily be some reason here that I'm missing that this is needed > here. My first impression, however, was that this extra clearing is > useless.
Yes, the extra clearing was useless. There are also some useless initializers for this variable and others.
Fine, apart from the description.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
| |