lkml.org 
[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for Feb 17 (pinctrl-msm)
On Mon 24 Feb 10:41 PST 2014, Josh Cartwright wrote:

[...]

>
> Without too much effort, I can get this to fail just by making
> CONFIG_PINCTRL_MSM=m. handle_bad_irq isn't marked EXPORT_SYMBOL*, so
> hence the warning.
>

Ohh, yeah I missed that.

> Whether or not this is intentional is not clear. Do we support modules
> installing chained irq handlers?
>
> For now, the patch below just makes this driver 'bool' instead of
> 'tristate'.

This comes from the request of having everything as a module, to reduce the
size of the multi-platform ARM builds. I would say that the important part
related to that would be to keep the platform specific tables in modules.

But keeping these parts as modules would still mean that it's a module that
install the chained irq handler.

@Linus, I'm not sure about what should be module and not in pinctrl, but this
part of pinctrl-msm is less important then the others to be able to be compiled
as a module.

FWIW;
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

>
> Josh

Regards,
Bjorn

>
> --8<--
> Subject: [PATCH] pinctrl: msm: make PINCTRL_MSM bool instead of tristate
>
> Modular builds of pinctrl-msm break due to handle_bad_irq being
> unexported for module use. For now, make PINCTRL_MSM 'bool'.
>
> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
> ---
> drivers/pinctrl/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index be361b7..1e4e693 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -217,7 +217,7 @@ config PINCTRL_IMX28
> select PINCTRL_MXS
>
> config PINCTRL_MSM
> - tristate
> + bool
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation


\
 
 \ /
  Last update: 2014-02-26 07:41    [W:0.059 / U:1.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site