lkml.org 
[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCHv1 3/6] HSI: hsi-char: add Device Tree support
On Sun, Feb 23, 2014 at 11:49:58PM +0000, Sebastian Reichel wrote:
> Add of_match_table to hsi_char driver, so that it can
> be referenced from Device Tree.
>
> Signed-off-by: Sebastian Reichel <sre@debian.org>
> ---
> drivers/hsi/clients/hsi_char.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
> index e61e5f9..7f64bed 100644
> --- a/drivers/hsi/clients/hsi_char.c
> +++ b/drivers/hsi/clients/hsi_char.c
> @@ -42,6 +42,7 @@
> #include <linux/stat.h>
> #include <linux/hsi/hsi.h>
> #include <linux/hsi/hsi_char.h>
> +#include <linux/of_device.h>
>
> #define HSC_DEVS 16 /* Num of channels */
> #define HSC_MSGS 4
> @@ -758,12 +759,22 @@ static int hsc_remove(struct device *dev)
> return 0;
> }
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id hsi_char_of_match[] = {
> + { .compatible = "ssi-char", },

This string is undocumented.

> + { .compatible = "hsi-char", },

I'm not sure either string makes sense though; this feels like a binding
for the sake of the driver rather than describing the device and
allowing the driver to pick it up if it makes sense to do so.

What exactly is a "ssi-char" device or a "hsi-char" device?

Cheers,
Mark.


\
 
 \ /
  Last update: 2014-02-25 10:01    [W:0.135 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site