Messages in this thread | | | From | Alistair Popple <> | Subject | Re: [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver | Date | Mon, 24 Feb 2014 11:28:01 +1100 |
| |
On Fri, 21 Feb 2014 10:41:50 Alan Stern wrote: > On Fri, 21 Feb 2014, Alistair Popple wrote: > > Currently the ppc-of driver uses the compatibility string > > "usb-ehci". This means platforms that use device-tree and implement an > > EHCI compatible interface have to either use the ppc-of driver or add > > a compatible line to the ehci-platform driver. It would be more > > appropriate for the platform driver to be compatible with "usb-ehci" > > as non-powerpc platforms are also beginning to utilise device-tree. > > > > This patch merges the device tree property parsing from ehci-ppc-of > > into the platform driver and adds a "usb-ehci" compatibility > > string. The existing ehci-ppc-of driver is removed and the 440EPX > > specific quirks are added to the ehci-platform driver. > > > > Signed-off-by: Alistair Popple <alistair@popple.id.au> > > This patch is also out of date. The compatibility string used by the > ehci-platform driver is "generic-ehci".
Ok. I will switch to using "generic-ehci" in the Akebono device tree.
> There remains the question of whether to merge ehci-ppc-of into > ehci-platform. This would be a rather invasive change, but I suppose > we could do it. With adjustments along the lines suggested by Mark > Rutland.
As I can use "generic-ehci" to support Akebono I will drop this patch. I can look at merging ehci-ppc-of at some later date if desired (thanks Mark & Tony for reviewing though).
- Alistair
> Alan Stern
| |