lkml.org 
[lkml]   [2014]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 10/11] watchdog: xilinx: Enable this driver for Zynq
    Hi Michal,

    > Enable this driver for Zynq.
    > Move it to architecture independent Kconfig part.
    >
    > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
    > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    > ---
    >
    > Changes in v3: None
    > Changes in v2: None
    >
    > Build tested by zero day testing system.
    > ---
    > drivers/watchdog/Kconfig | 22 +++++++++-------------
    > 1 file changed, 9 insertions(+), 13 deletions(-)
    >
    > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
    > index 9db5d3c..6120403 100644
    > --- a/drivers/watchdog/Kconfig
    > +++ b/drivers/watchdog/Kconfig
    > @@ -111,6 +111,15 @@ config WM8350_WATCHDOG
    > Support for the watchdog in the WM8350 AudioPlus PMIC. When
    > the watchdog triggers the system will be reset.
    >
    > +config XILINX_WATCHDOG
    > + tristate "Xilinx Watchdog timer"
    > + select WATCHDOG_CORE
    > + help
    > + Watchdog driver for the xps_timebase_wdt ip core.
    > +
    > + To compile this driver as a module, choose M here: the
    > + module will be called of_xilinx_wdt.
    > +
    > # ALPHA Architecture
    >
    > # ARM Architecture
    > @@ -1022,19 +1031,6 @@ config M54xx_WATCHDOG
    >
    > # MicroBlaze Architecture
    >
    > -config XILINX_WATCHDOG
    > - tristate "Xilinx Watchdog timer"
    > - depends on MICROBLAZE
    > - select WATCHDOG_CORE
    > - ---help---
    > - Watchdog driver for the xps_timebase_wdt ip core.
    > -
    > - IMPORTANT: The xps_timebase_wdt parent must have the property
    > - "clock-frequency" at device tree.
    > -
    > - To compile this driver as a module, choose M here: the
    > - module will be called of_xilinx_wdt.
    > -
    > # MIPS Architecture
    >
    > config ATH79_WDT
    > --
    > 1.8.2.3
    >

    Are we sure that we don't need an additional dependancy (like depends on HAS_IOMEM) to not have issues with other architectures?

    Kind regards,
    Wim.



    \
     
     \ /
      Last update: 2014-02-22 20:21    [W:2.324 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site