Messages in this thread Patch in this message | | | Date | Sat, 22 Feb 2014 09:57:44 -0800 | From | tip-bot for Jiri Olsa <> | Subject | [tip:perf/core] perf tools: Fix dwarf unwind max_stack processing |
| |
Commit-ID: b42dc32d4f91e4c0f34b628fdb012eb423da9e69 Gitweb: http://git.kernel.org/tip/b42dc32d4f91e4c0f34b628fdb012eb423da9e69 Author: Jiri Olsa <jolsa@redhat.com> AuthorDate: Tue, 7 Jan 2014 13:47:23 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 18 Feb 2014 09:34:47 -0300
perf tools: Fix dwarf unwind max_stack processing
The 'unwind__get_entries' function currently returns 'max_stack + 1' entries (instead of exact max_stack entries), because max_stack value does not get decremented for the first entry.
This fix makes dwarf-unwind test pass.
Signed-off-by: Jiri Olsa <jolsa@redhat.com> Acked-by: Jean Pihet <jean.pihet@linaro.org> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jean Pihet <jean.pihet@linaro.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1389098853-14466-7-git-send-email-jolsa@redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/unwind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/unwind.c b/tools/perf/util/unwind.c index 742f23b..bff3209 100644 --- a/tools/perf/util/unwind.c +++ b/tools/perf/util/unwind.c @@ -595,5 +595,5 @@ int unwind__get_entries(unwind_entry_cb_t cb, void *arg, if (ret) return -ENOMEM; - return get_entries(&ui, cb, arg, max_stack); + return --max_stack > 0 ? get_entries(&ui, cb, arg, max_stack) : 0; }
| |