Messages in this thread | | | Date | Sat, 22 Feb 2014 15:32:53 +1300 | From | Tony Prisk <> | Subject | Re: [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver |
| |
On 22/02/14 00:48, Mark Rutland wrote: > [Adding Tony Prisk to Cc] > > On Fri, Feb 21, 2014 at 06:31:30AM +0000, Alistair Popple wrote: >> Currently the ppc-of driver uses the compatibility string >> "usb-ehci". This means platforms that use device-tree and implement an >> EHCI compatible interface have to either use the ppc-of driver or add >> a compatible line to the ehci-platform driver. It would be more >> appropriate for the platform driver to be compatible with "usb-ehci" >> as non-powerpc platforms are also beginning to utilise device-tree. >> >> This patch merges the device tree property parsing from ehci-ppc-of >> into the platform driver and adds a "usb-ehci" compatibility >> string. The existing ehci-ppc-of driver is removed and the 440EPX >> specific quirks are added to the ehci-platform driver. >> >> Signed-off-by: Alistair Popple <alistair@popple.id.au> >> --- >> drivers/usb/host/Kconfig | 7 +- >> drivers/usb/host/ehci-hcd.c | 5 - >> drivers/usb/host/ehci-platform.c | 87 +++++++++++++- >> drivers/usb/host/ehci-ppc-of.c | 238 -------------------------------------- >> 4 files changed, 89 insertions(+), 248 deletions(-) >> delete mode 100644 drivers/usb/host/ehci-ppc-of.c > Please use of_property_read_bool for these. > > This driver already handles "via,vt8500-ehci" and "wm,prizm-ehci" which > aren't documented to handle these properties, but now gain support for > them. It might be worth unifying the binding documents if there's > nothing special about those two host controllers. > > We seem to have two binding documents for "via,vt8500-ehci", so some > cleanup is definitely in order. > > Tony, you seem to have written both documents judging by 95e9fd10f06c > and 8ad551d150e3. Do you have any issue with merging both of these into > a common usb-ehci document? ...... > Cheers, > Mark.
I'm not sure how we ended up with two bindings for the driver anyway. I think this was an error on my part somewhere.
None of the in-tree dts files use "wm,prizm-ehci".
I have no issue with merging all the documentation into a single usb-ehci binding.
Regards Tony Prisk
| |