Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Add test for char * arrays that could be static const | From | Joe Perches <> | Date | Fri, 21 Feb 2014 17:18:51 -0800 |
| |
static const char* arrays create smaller text as each function call does not have to populate the array.
Emit a warning when char *arrays aren't static const and the array is not apparently global by being declared in the first column.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 646295c..2e6257b 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2675,6 +2675,13 @@ sub process { $herecurr); } +# check for non-global char *foo[] = {"bar", ...} declarations. + if ($line =~ /^.\s+(?:static\s+|const\s+)?char\s+\*\s*\w+\s*\[\s*\]\s*=\s*\{/) { + WARN("STATIC_CONST_CHAR_ARRAY", + "char * array declaration might be better as static const\n" . + $herecurr); + } + # check for function declarations without arguments like "int foo()" if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) { if (ERROR("FUNCTION_WITHOUT_ARGS",
| |