Messages in this thread | | | Date | Fri, 21 Feb 2014 10:13:26 -0500 | From | Peter Hurley <> | Subject | Re: [PATCH 8/9] staging/fwserial: don't use PREPARE_WORK |
| |
On 02/20/2014 03:44 PM, Tejun Heo wrote: > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > and a nasty surprise in terms of reentrancy guarantee as workqueue > considers work items to be different if they don't have the same work > function. > > fwtty_peer->work is multiplexed with multiple work functions. > Introduce fwserial_peer_workfn() which invokes fwtty_peer->workfn and > always use it as the work function and update the users to set the > ->workfn field instead of overriding the work function using > PREPARE_WORK(). > > It would probably be best to route this with other related updates > through the workqueue tree. > > Compile tested. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Peter Hurley <peter@hurleysoftware.com>
Acked-by: Peter Hurley <peter@hurleysoftware.com>
| |