lkml.org 
[lkml]   [2014]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.5 28/60] staging:iio:ad799x fix error_free_irq which was freeing an irq that may not have been requested
    Date
    3.5.7.31 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hartmut Knaack <knaack.h@gmx.de>

    commit 38408d056188be29a6c4e17f3703c796551bb330 upstream.

    Only free an IRQ in error_free_irq, if it has been requested previously.

    Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
    Acked-by: Lars-Peter Clausen <lars@metafoo.de>
    Signed-off-by: Jonathan Cameron <jic23@kernel.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/staging/iio/adc/ad799x_core.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
    index 80e0c6e..b50d1df 100644
    --- a/drivers/staging/iio/adc/ad799x_core.c
    +++ b/drivers/staging/iio/adc/ad799x_core.c
    @@ -911,7 +911,8 @@ static int __devinit ad799x_probe(struct i2c_client *client,
    return 0;

    error_free_irq:
    - free_irq(client->irq, indio_dev);
    + if (client->irq > 0)
    + free_irq(client->irq, indio_dev);
    error_cleanup_ring:
    ad799x_ring_cleanup(indio_dev);
    error_disable_reg:
    --
    1.9.0


    \
     
     \ /
      Last update: 2014-02-21 15:01    [W:4.523 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site