Messages in this thread Patch in this message | | | From | Stewart Smith <> | Subject | [PATCH] scsi/sd.c: fix spun up and not ready messages to mention which disk | Date | Fri, 21 Feb 2014 11:34:43 +1100 |
| |
Previously, many years ago, this was done in series which was fine, but things moved to be done in parallel and with many disks in a system it can be hard to see which disk spun up and which one didn't as the printk messages were all mixed together.
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> --- drivers/scsi/sd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 470954a..1436c85 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1838,7 +1838,6 @@ sd_spinup_disk(struct scsi_disk *sdkp) } /* Wait 1 second for next try */ msleep(1000); - printk("."); /* * Wait for USB flash devices with slow firmware. @@ -1868,9 +1867,9 @@ sd_spinup_disk(struct scsi_disk *sdkp) if (spintime) { if (scsi_status_is_good(the_result)) - printk("ready\n"); + sd_printk(KERN_NOTICE, sdkp, "ready\n"); else - printk("not responding...\n"); + sd_printk(KERN_NOTICE, sdkp, "not responding...\n"); } } -- 1.8.5.3
| |