lkml.org 
[lkml]   [2014]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 20/82] iwlwifi: mvm: dont allow A band if SKU forbids it
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

    commit c512865446e6dd5b6e91e81187e75b734ad7cfc7 upstream.

    The driver wasn't reading the NVM properly. While this
    didn't lead to any issue until now, it seems that there
    is an old version of the NVM in the wild.
    In this version, the A band channels appear to be valid
    but the SKU capabilities (another field of the NVM) says
    that A band isn't supported at all.
    With this specific version of the NVM, the driver would
    think that A band is supported while the HW / firmware
    don't. This leads to asserts.

    Reviewed-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/iwlwifi/iwl-nvm-parse.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/net/wireless/iwlwifi/iwl-nvm-parse.c
    +++ b/drivers/net/wireless/iwlwifi/iwl-nvm-parse.c
    @@ -182,6 +182,11 @@ static int iwl_init_channel_map(struct d

    for (ch_idx = 0; ch_idx < IWL_NUM_CHANNELS; ch_idx++) {
    ch_flags = __le16_to_cpup(nvm_ch_flags + ch_idx);
    +
    + if (ch_idx >= NUM_2GHZ_CHANNELS &&
    + !data->sku_cap_band_52GHz_enable)
    + ch_flags &= ~NVM_CHANNEL_VALID;
    +
    if (!(ch_flags & NVM_CHANNEL_VALID)) {
    IWL_DEBUG_EEPROM(dev,
    "Ch. %d Flags %x [%sGHz] - No traffic\n",



    \
     
     \ /
      Last update: 2014-02-21 02:21    [W:4.029 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site