Messages in this thread | | | Date | Thu, 20 Feb 2014 17:46:36 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH 7/9] afs: don't use PREPARE_WORK |
| |
On Thu, Feb 20, 2014 at 10:00:05PM +0000, David Howells wrote: > Tejun Heo <tj@kernel.org> wrote: > > > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > > and a nasty surprise in terms of reentrancy guarantee as workqueue > > considers work items to be different if they don't have the same work > > function. > > Why so? Isn't the work item address sufficient to distinguish them?
Because we ended up introducing deadlocks through work items which are freed and then recycled.
Thanks.
-- tejun
| |