lkml.org 
[lkml]   [2014]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 20/23] regulator: wm831x-dcdc: Remove redundant error message
    Date
    kzalloc prints its own OOM message upon failure.

    Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
    ---
    drivers/regulator/wm831x-dcdc.c | 16 ++++------------
    1 file changed, 4 insertions(+), 12 deletions(-)

    diff --git a/drivers/regulator/wm831x-dcdc.c b/drivers/regulator/wm831x-dcdc.c
    index 04cf9c16ef23..0d88a82ab2a2 100644
    --- a/drivers/regulator/wm831x-dcdc.c
    +++ b/drivers/regulator/wm831x-dcdc.c
    @@ -469,10 +469,8 @@ static int wm831x_buckv_probe(struct platform_device *pdev)

    dcdc = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_dcdc),
    GFP_KERNEL);
    - if (dcdc == NULL) {
    - dev_err(&pdev->dev, "Unable to allocate private data\n");
    + if (!dcdc)
    return -ENOMEM;
    - }

    dcdc->wm831x = wm831x;

    @@ -622,10 +620,8 @@ static int wm831x_buckp_probe(struct platform_device *pdev)

    dcdc = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_dcdc),
    GFP_KERNEL);
    - if (dcdc == NULL) {
    - dev_err(&pdev->dev, "Unable to allocate private data\n");
    + if (!dcdc)
    return -ENOMEM;
    - }

    dcdc->wm831x = wm831x;

    @@ -752,10 +748,8 @@ static int wm831x_boostp_probe(struct platform_device *pdev)
    return -ENODEV;

    dcdc = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_dcdc), GFP_KERNEL);
    - if (dcdc == NULL) {
    - dev_err(&pdev->dev, "Unable to allocate private data\n");
    + if (!dcdc)
    return -ENOMEM;
    - }

    dcdc->wm831x = wm831x;

    @@ -842,10 +836,8 @@ static int wm831x_epe_probe(struct platform_device *pdev)
    dev_dbg(&pdev->dev, "Probing EPE%d\n", id + 1);

    dcdc = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_dcdc), GFP_KERNEL);
    - if (dcdc == NULL) {
    - dev_err(&pdev->dev, "Unable to allocate private data\n");
    + if (!dcdc)
    return -ENOMEM;
    - }

    dcdc->wm831x = wm831x;

    --
    1.7.9.5


    \
     
     \ /
      Last update: 2014-02-20 11:41    [W:4.081 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site