Messages in this thread Patch in this message | | | From | David Fries <> | Subject | [PATCH 2/4] w1: only send_error when there is an error | Date | Sun, 2 Feb 2014 19:15:01 -0600 |
| |
Otherwise there's an extra reply being sent out for each async message. Some commands such as W1_CMD_LIST_SLAVES will be identical except one message has data and the other doesn't making it difficult for a program to know if all the slaves just vanished or what happened.
Signed-off-by: David Fries <David@Fries.net> --- drivers/w1/w1_netlink.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c index a02704a..a6962f5 100644 --- a/drivers/w1/w1_netlink.c +++ b/drivers/w1/w1_netlink.c @@ -423,9 +423,11 @@ static void w1_process_cb(struct w1_master *dev, struct w1_async_cmd *async_cmd) err = w1_process_command_master(dev, &node->block->msg, node->m, cmd); - w1_netlink_send_error(&node->block->msg, node->m, cmd, - node->block->portid, err); - err = 0; + if (err) { + w1_netlink_send_error(&node->block->msg, node->m, cmd, + node->block->portid, err); + err = 0; + } cmd_data += cmd->len + sizeof(struct w1_netlink_cmd); mlen -= cmd->len + sizeof(struct w1_netlink_cmd); -- 1.7.10.4
| |