Messages in this thread | | | Date | Wed, 19 Feb 2014 10:57:13 +0800 | From | Aaron Lu <> | Subject | Re: [PATCH v4] ACPI / video: Add systems that should favour native backlight interface |
| |
On 02/18/2014 11:46 PM, Mika Westerberg wrote: > On Tue, Feb 18, 2014 at 04:22:27PM +0100, Rafael J. Wysocki wrote: >> On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote: >>> At Tue, 18 Feb 2014 12:34:42 +0200, >>> Mika Westerberg wrote: >>>> >>>> On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: >>>>> + { >>>>> + .callback = video_set_use_native_backlight, >>>>> + .ident = "HP EliteBook 2013 models", >>>>> + .matches = { >>>>> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), >>>>> + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "), >>>>> + DMI_MATCH(DMI_PRODUCT_NAME, " G1"), >>>>> + }, >>>>> + }, >>>> >>>> I see my device is listed here but the above doesn't really use native >>>> backlight because it is still in acpi_osi blacklist. Tried this and I can >>>> see both acpi_video0 and intel_backlight listed under /sys/class/backlight. >>>> Was this the intention? >>> >>> The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I >>> mentioned earlier. But the revert can be done individually after >>> merging this patch. Rafael, could you care? >> >> Done. Please check the result in linux-pm.git/linux-next. > > With your revert and this patch from Aaron, backlight on my HP EliteBook > Revolve G1 works fine, thanks! > > Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks for the test Mika and sorry for all the confusions caused.
-Aaron
| |