Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 4/5] intel_pstate: Use LFM bus ratio as min ratio/P state | Date | Wed, 19 Feb 2014 01:58:59 +0100 |
| |
On Wednesday, February 12, 2014 10:01:06 AM dirk.brandewie@gmail.com wrote: > From: Dirk Brandewie <dirk.j.brandewie@intel.com> > > Using LFM ratio provides better perf/watt vs min ratio. > > Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
This changelog is particularly insufficient.
Can you please explain what's wrong with the previous calculation and how the change makes it better?
> --- > drivers/cpufreq/intel_pstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index b80c03d..ff45ce1 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -356,7 +356,7 @@ static int byt_get_min_pstate(void) > { > u64 value; > rdmsrl(BYT_RATIOS, value); > - return value & 0xFF; > + return (value >> 8) & 0xFF; > } > > static int byt_get_max_pstate(void) >
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |