lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 27/40] [media] mxl111sf: Fix unintentional garbage stack read
    Date
    3.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dave Jones <davej@fedoraproject.org>

    commit 866e8d8a9dc1ebb4f9e67197e264ac2df81f7d4b upstream.

    mxl111sf_read_reg takes an address of a variable to write to as an argument.
    drivers/media/usb/dvb-usb-v2/mxl111sf-gpio.c:mxl111sf_config_pin_mux_modes
    passes several uninitialized stack variables to this routine, expecting
    them to be filled in. In the event that something unexpected happens when
    reading from the chip, we end up doing a pr_debug of the value passed in,
    revealing whatever garbage happened to be on the stack.

    Change the pr_debug to match what happens in the 'success' case, where we
    assign buf[1] to *data.

    Spotted with Coverity (Bugs 731910 through 731917)

    Signed-off-by: Dave Jones <davej@fedoraproject.org>
    Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
    Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/usb/dvb-usb-v2/mxl111sf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
    +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
    @@ -105,7 +105,7 @@ int mxl111sf_read_reg(struct mxl111sf_st
    ret = -EINVAL;
    }

    - pr_debug("R: (0x%02x, 0x%02x)\n", addr, *data);
    + pr_debug("R: (0x%02x, 0x%02x)\n", addr, buf[1]);
    fail:
    return ret;
    }



    \
     
     \ /
      Last update: 2014-02-19 00:41    [W:3.001 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site