Messages in this thread | | | Date | Tue, 18 Feb 2014 10:26:49 -0800 | Subject | Re: [PATCH] Makefile: fix extra parenthesis typo when CC_STACKPROTECTOR_REGULAR is enabled | From | Kees Cook <> |
| |
On Mon, Feb 17, 2014 at 1:42 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote: > extra parenthesis typo introduced in commit 19952a9203 is causing > the following error when CONFIG_CC_STACKPROTECTOR_REGULAR is enabled: > Makefile:608: Cannot use CONFIG_CC_STACKPROTECTOR: -fstack-protector not > supported by compiler > Makefile:608: *** missing separator. Stop.
Yikes! I have no idea how that snuck in. :( Thank you for noticing and fixing this.
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
Acked-by: Kees Cook <keescook@chromium.org>
Thanks!
-Kees
> --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 893d6f0..eeaf3e7 100644 > --- a/Makefile > +++ b/Makefile > @@ -606,7 +606,7 @@ ifdef CONFIG_CC_STACKPROTECTOR_REGULAR > stackp-flag := -fstack-protector > ifeq ($(call cc-option, $(stackp-flag)),) > $(warning Cannot use CONFIG_CC_STACKPROTECTOR: \ > - -fstack-protector not supported by compiler)) > + -fstack-protector not supported by compiler) > endif > else ifdef CONFIG_CC_STACKPROTECTOR_STRONG > stackp-flag := -fstack-protector-strong > -- > 1.8.1.2 >
-- Kees Cook Chrome OS Security
| |