Messages in this thread | | | Date | Tue, 18 Feb 2014 09:33:14 +0900 | From | Mark Brown <> | Subject | Re: [PATCH 03/15] ASoC: adav80x: Update locking around use of DAPM pin API |
| |
On Mon, Feb 17, 2014 at 04:51:31PM +0000, Charles Keepax wrote:
> + mutex_lock(&codec->dapm.card->dapm_mutex); > +
I think this needs a helper that just takes the CODEC as an argument and does the lookup - a static inline in the header would be fine. The big long dereference is ugly for something people should be doing and will be annoying if we want to refactor in the future. [unhandled content-type:application/pgp-signature] | |