Messages in this thread | | | Date | Mon, 17 Feb 2014 18:46:48 +0100 | From | Oleg Nesterov <> | Subject | Re: 3.14-rc2 XFS backtrace because irqs_disabled. |
| |
On 02/17, Al Viro wrote: > > On Mon, Feb 17, 2014 at 05:57:35PM +0100, Oleg Nesterov wrote: > > > Looks like, this is all is really nasty. Actually, I think siginfo on > > stack is not that bad if we are going to do handle_signal() or restart, > > perhaps we can do the extra kmalloc/memcpy/kfree for do_coredump(). > > Something like below. > > Yecchhhh... You've just broken every architecture other than x86,
Of course, this is only to explain what I meant.
> and to > fix them you'll need to massage every get_signal()/get_signal_to_deliver() > user out there,
Yes.
> pulling the logics *out* of kernel/signal.c and into arch/*.
Not really, I think. Of course this change should be cleanuped. And it should not require to change all architectures at once.
> This is just plain wrong.
I agree, this change is also ugly.
Oleg.
| |