Messages in this thread Patch in this message | | | From | Petr Mladek <> | Subject | [PATCH 4/4] x86: Fix order of warning messages when ftrace modifies code | Date | Mon, 17 Feb 2014 16:22:53 +0100 |
| |
The colon at the end of the printk message suggests that it should get printed before the details printed by ftrace_bug().
When touching the line, let's use the preferred pr_warn() macro as suggested by checkpatch.pl.
Signed-off-by: Petr Mladek <pmladek@suse.cz> --- arch/x86/kernel/ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index 525a9f954c8b..ad7c38f5206b 100644 --- a/arch/x86/kernel/ftrace.c +++ b/arch/x86/kernel/ftrace.c @@ -622,8 +622,8 @@ void ftrace_replace_code(int enable) return; remove_breakpoints: + pr_warn("Failed on %s (%d):\n", report, count); ftrace_bug(ret, rec ? rec->ip : 0); - printk(KERN_WARNING "Failed on %s (%d):\n", report, count); for_ftrace_rec_iter(iter) { int err; -- 1.8.4
| |