Messages in this thread | | | Date | Mon, 17 Feb 2014 15:12:22 +0000 | From | One Thousand Gnomes <> | Subject | Re: [PATCH V2] serial/uart: Add tunable RX interrupt trigger I/F of FIFO buffers |
| |
> According to HW specification of serial UART devices, RX interrupt trigger > can be changed, but the trigger is hard-coded. For example, RX interrupt trigger > in 16550A can be set to 1, 4, 8, or 14 bytes for HW, but current driver sets > the trigger to only 8bytes. > > This patch makes a 16550A device change RX interrupt trigger from userland.
We probably need to be much smarter about how we set this as lots of non 16550A type devices have a tunable trigger.
We tune it dynamically based upon baud rate for many platforms, and we turn it on and off according to low latency settings. In other words we can't just have an ioctl poking values about in parallel and without any locking.
For the API IMHO this really belongs in sysfs IMHO. That does mean we need to turn the existing sysfs API read/write by adding a few set methods not just get ones in drivers/tty/serial/ but it would be a lot cleaner and the uart_set_info path does the correct stopping and restarting as well as locking for the fifo size change.
Alan
| |