Messages in this thread | | | From | Kay Sievers <> | Date | Mon, 17 Feb 2014 01:50:39 +0100 | Subject | Re: [PATCH] printk: Fix discarding of records |
| |
On Mon, Feb 17, 2014 at 1:41 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata > <dbanerje@akamai.com> wrote:
> The third loop does *not* start again from the first line! It > *continues* from where the second loop ended. Which is exactly why > clearing "prev" is *wrong*. Because the *last* line that the second > loop processes is indeed the previous line before the *first* line > that the third loop starts processing. > > No, I haven't tested my patch, and maybe it's broken for some subtle > reason I'm missing too.
That should avoid the overflow, yes. I expect it will not print the first line with a prefix, which we probably should.?
Kay
| |