lkml.org 
[lkml]   [2014]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] mfd: MAX6650/6651 support
On Fri, Feb 14, 2014 at 09:02:20AM +0000, Laszlo Papp wrote:
> On Wed, Feb 12, 2014 at 5:50 PM, Mark Brown <broonie@kernel.org> wrote:
> > On Wed, Feb 12, 2014 at 04:02:40AM +0000, Laszlo Papp wrote:

> >> +const struct regmap_config max665x_regmap_config = {
> >> + .reg_bits = 5,
> >> +};

> > This would normally be static too, and I'd *really* expect to see a
> > val_bits set here. I'm a bit surprised this works without one.

> Makes sense, thanks. Shall I also set the .max_register or any other
> mandatory variables in here?

It's better to set max_register since that makes the debug features of
the regmap API more useful but it's not required, only reg_bits and
val_bits are absolutely required. In general the more complete the
description of the register map in the driver the better.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-02-15 12:01    [W:0.079 / U:3.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site