Messages in this thread | | | Date | Sat, 15 Feb 2014 17:47:48 -0600 | From | Felipe Balbi <> | Subject | Re: [PATCH v5 1/6] spmi: Linux driver framework for SPMI |
| |
Hi,
On Mon, Feb 03, 2014 at 05:05:33PM -0600, Josh Cartwright wrote:
[ snip ]
> +#ifdef CONFIG_PM_RUNTIME > +static int spmi_runtime_suspend(struct device *dev) > +{ > + struct spmi_device *sdev = to_spmi_device(dev); > + int err; > + > + err = pm_generic_runtime_suspend(dev); > + if (err) > + return err; > + > + return spmi_command_sleep(sdev);
shouldn't this too calls be swapped ? I mean, some pm_runtime implementations could be gating clocks at the driver's ->runtime_suspend() callback.
-- balbi [unhandled content-type:application/pgp-signature] | |