Messages in this thread | | | Date | Sat, 15 Feb 2014 12:41:58 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 2/3] staging: r8188eu: delete unnecessary field initialization |
| |
On Sat, Feb 15, 2014 at 08:36:12AM +0100, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > On success, the function netdev_alloc_skb initializes the dev field of its > result to its first argument, so this doesn't have to be done in the > calling context. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression skb,privn,e; > @@ > > skb = netdev_alloc_skb(privn,...); > ... when strict > ( > -skb->dev = privn; > | > ?skb = e > ) > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 1 - > 1 file changed, 1 deletion(-)
No longer applies to my tree :(
| |