[lkml]   [2014]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCHv3 2/6] mailbox: Introduce a new common API
On Sat, Feb 15, 2014 at 11:55:27PM +0530, Jassi Brar wrote:
> +typedef unsigned request_token_t;

Ick. Why add a new typedef? And if you do need this, drop the "_t" on
the end please.

Why not just rely on an unsigned int? Or long? Do you really need a
new type?


greg k-h

 \ /
  Last update: 2014-02-15 20:41    [W:0.107 / U:34.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site