lkml.org 
[lkml]   [2014]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Drivers: net: wireless: mac80211_hwim fixed coding style issues
From
Date
On Sat, 2014-02-15 at 12:55 +0100, Justin van Wijngaarden wrote:

> @@ -1,19 +1,17 @@
> -/*
> - * mac80211_hwsim - software simulator of 802.11 radio(s) for mac80211
> +/* mac80211_hwsim - software simulator of 802.11 radio(s) for mac80211

I don't see any point in this - lots of code exists both ways, that's
really just fluff. The difference isn't even interesting enough to be
worth fixing up.

> * published by the Free Software Foundation.
> - */
> +*/

That's just wrong.

In any case, your patch won't apply anyway since we've since
changed/removed code that you're modifying.

There's very little in this patch that I'd be willing to apply, and most
of that you actually got the coding style wrong so it's not an
improvement at all.

johannes



\
 
 \ /
  Last update: 2014-02-15 19:41    [W:0.046 / U:36.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site