Messages in this thread | | | Date | Wed, 12 Feb 2014 09:34:28 +0000 | Subject | Re: [PATCH v6] mfd: MAX6650/6651 support | From | Laszlo Papp <> |
| |
On Wed, Feb 12, 2014 at 8:32 AM, Lee Jones <lee.jones@linaro.org> wrote: >> >> + max665x->map = devm_regmap_init_i2c(i2c, &max665x_regmap_config); >> > >> > Don't you need to check the return value of devm_regmap_init_i2c? >> >> I personally think I should. I strived for consistency though with >> other similar drivers. After this many reviews about such things, it >> seems that consistency matters here less than other projects which I >> can cope with, thanks. > > The right thing to do is normally preferred.
Yes, sure.
| |