Messages in this thread | | | Date | Wed, 12 Feb 2014 08:41:34 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH 09/12] hwmon: vexpress: Use devm helper for hwmon device registration |
| |
On Wed, Feb 12, 2014 at 11:56:36AM +0000, Pawel Moll wrote: > > > I agree with Arnd that it would be nice to get rid of the local macro, > > but I won't mandate that. > > I actually prefer to have the structures unfolded, but was just trying > to mimic the trend in other hwmon drivers. No problem - will change this > gladly. > In general we tend to discourage people to use their own macros - most of the time it just makes the code more difficult to read.
Guenter
| |